Skip to content

Remove unused 'progress' parameter from the AttachmentPresenter #7644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Remove unused 'progress' parameter from the AttachmentPresenter #7644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18be16e
remove unused progress parameters from attachmentsgrid
denis-tingaikin Jan 12, 2025
f728e4e
fast formating
denis-tingaikin Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plugins/attachment-resources/src/components/AttachmentPresenter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!--
// Copyright © 2020, 2021 Anticrm Platform Contributors.
// Copyright © 2021 Hardcore Engineering Inc.
// Copyright © 2021, 2025 Hardcore Engineering Inc.
//
// Licensed under the Eclipse Public License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. You may
Expand Down Expand Up @@ -35,7 +35,6 @@
export let removable: boolean = false
export let showPreview = false
export let preview = false
export let progress: boolean = false

const dispatch = createEventDispatcher()

Expand Down
3 changes: 1 addition & 2 deletions plugins/attachment-resources/src/components/AttachmentStyleBoxCollabEditor.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
// Copyright © 2023 Hardcore Engineering Inc.
// Copyright © 2023 2025 Hardcore Engineering Inc.
//
// Licensed under the Eclipse Public License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. You may
Expand Down Expand Up @@ -333,7 +333,6 @@
{attachments}
{readonly}
{progress}
{progressItems}
{useAttachmentPreview}
on:remove={async (evt) => {
if (evt.detail !== undefined) {
Expand Down
3 changes: 1 addition & 2 deletions plugins/attachment-resources/src/components/AttachmentStyledBox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
// Copyright © 2022 Hardcore Engineering Inc.
// Copyright © 2022, 2025 Hardcore Engineering Inc.
//
// Licensed under the Eclipse Public License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. You may
Expand Down Expand Up @@ -440,7 +440,6 @@
<AttachmentsGrid
attachments={Array.from(attachments.values())}
{progress}
{progressItems}
{useAttachmentPreview}
on:remove={async (evt) => {
if (evt.detail !== undefined) {
Expand Down
12 changes: 2 additions & 10 deletions plugins/attachment-resources/src/components/AttachmentsGrid.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
// Copyright © 2023 Hardcore Engineering Inc.
// Copyright © 2023, 2025 Hardcore Engineering Inc.
//
// Licensed under the Eclipse Public License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. You may
Expand All @@ -14,7 +14,6 @@
-->
<script lang="ts">
import { Attachment } from '@hcengineering/attachment'
import { Doc, Ref } from '@hcengineering/core'
import { Loading, updatePopup, Scroller } from '@hcengineering/ui'
import { ListSelectionProvider } from '@hcengineering/view-resources'
import AttachmentPresenter from './AttachmentPresenter.svelte'
Expand All @@ -23,7 +22,6 @@
export let attachments: Attachment[] = []
export let useAttachmentPreview = false
export let progress = false
export let progressItems: Ref<Doc>[] = []
export let readonly: boolean = false

let element: HTMLElement
Expand Down Expand Up @@ -54,13 +52,7 @@
on:open={(res) => (attachmentPopupId = res.detail)}
/>
{:else}
<AttachmentPresenter
value={attachment}
removable={!readonly}
showPreview
progress={progressItems.includes(attachment._id)}
on:remove
/>
<AttachmentPresenter value={attachment} removable={!readonly} showPreview on:remove />
{/if}
{/each}
{#if progress}
Expand Down
Loading