From b4ec1205f03de6eb823cba81dd81bf89effccd2d Mon Sep 17 00:00:00 2001 From: hchiam Date: Sun, 4 Aug 2019 12:13:48 -0400 Subject: [PATCH] fix #19 --- CHANGELOG.md | 4 ++++ package-lock.json | 2 +- package.json | 2 +- src/extension.ts | 8 ++++++++ visually-check-this.js | 5 +++++ 5 files changed, 19 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5708922..ef9f538 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to the "custom-vscode-linter" extension will be documented in this file. +## 0.7.0 + +- Added check for `TODO` comments. + ## 0.6.0 - Added check for `Number(someID)` diff --git a/package-lock.json b/package-lock.json index b1c4665..a9851c4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "custom-vscode-linter", - "version": "0.6.5", + "version": "0.7.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index c73d694..8404552 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "custom-vscode-linter", "displayName": "custom-vscode-linter", "description": "Custom VSCode Linter!", - "version": "0.6.5", + "version": "0.7.0", "publisher": "hchiam", "repository": { "type": "git", diff --git a/src/extension.ts b/src/extension.ts index 782ae17..aa6c9b0 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -57,6 +57,7 @@ export function activate(context: vscode.ExtensionContext) { check_encryptedSQL(rangesToDecorate); check_consoleLog(rangesToDecorate); check_numberOfId(rangesToDecorate); + check_todoComment(rangesToDecorate); activeEditor.setDecorations(decorationType, rangesToDecorate); } @@ -116,6 +117,13 @@ export function activate(context: vscode.ExtensionContext) { genericCheck(regex, hoverMessage, popupMessage, rangesToDecorate); } + function check_todoComment(rangesToDecorate: vscode.DecorationOptions[]) { + let regex = /(\/\/|--) ?TODO/g; + let hoverMessage = 'To-do comment detected.'; + let popupMessage = 'To-do comment detected.'; + genericCheck(regex, hoverMessage, popupMessage, rangesToDecorate); + } + function genericCheck(regex: RegExp = /^$/, hoverMessage: string = '', popupMessage: string = '', rangesToDecorate: vscode.DecorationOptions[] = []) { if (!activeEditor) { return; diff --git a/visually-check-this.js b/visually-check-this.js index 2461ffb..031ac01 100644 --- a/visually-check-this.js +++ b/visually-check-this.js @@ -96,3 +96,8 @@ Number(-1 || someId) // NO if (!someID) { // YES } + +// TODO // YES +//TODO:// YES +-- TODO: // YES +--TODO // YES