Skip to content

Horia Chiorean
hchiorean

  • Joined on Aug 22, 2011

Organizations

@ModeShape
hchiorean deleted branch MODE-2602 at hchiorean/modeshape
May 27, 2016
May 27, 2016
@hchiorean
May 27, 2016
hchiorean merged pull request ModeShape/modeshape#1564
@hchiorean
MODE-2602 Updates the WF kit so that module names for built-in components don't require explicit configuration
1 commit with 184 additions and 107 deletions
May 27, 2016
hchiorean opened pull request ModeShape/modeshape#1564
@hchiorean
MODE-2602 Updates the WF kit so that module names for built-in components don't require explicit configuration
1 commit with 184 additions and 107 deletions
May 27, 2016
hchiorean deleted branch MODE-2558 at hchiorean/modeshape
May 25, 2016
May 25, 2016
@hchiorean
  • @hchiorean 2b9eb0c
    Merge pull request #1563 from hchiorean/MODE-2558
  • @hchiorean 9f1a30c
    MODE-2550 Adds the ODF sequencer to the WF kit plus a small number of…
  • 4 more commits »
May 25, 2016
hchiorean merged pull request ModeShape/modeshape#1563
@hchiorean
Updates the WF kit with the new sequencers plus some other minor changes
5 commits with 429 additions and 223 deletions
May 25, 2016
hchiorean commented on pull request ModeShape/modeshape#1563
@hchiorean

updated the PR with an additional commit which contains the changes for the ODF sequencer

May 25, 2016
@hchiorean
  • @hchiorean 9f1a30c
    MODE-2550 Adds the ODF sequencer to the WF kit plus a small number of…
  • @hchiorean 12d34c6
    MODE-2551 Adds the EPUB sequencer to the WF kit plus a small number o…
  • 5 more commits »
May 24, 2016
@hchiorean
May 24, 2016
hchiorean merged pull request ModeShape/modeshape#1562
@hchiorean
MODE-2550 Adds OpenDocument Format sequencer
1 commit with 785 additions and 0 deletions
May 24, 2016
@hchiorean
  • @hchiorean 4d8cbfc
    MODE-2551 Adds the EPUB sequencer to the WF kit plus a small number o…
May 24, 2016
hchiorean opened pull request ModeShape/modeshape#1563
@hchiorean
Updates the WF kit with the new sequencers plus some other minor changes
4 commits with 364 additions and 209 deletions
May 24, 2016
May 24, 2016
hchiorean commented on pull request ModeShape/modeshape#1562
@hchiorean

@RobSis: can you please fix the above error and update the PR (push -f). thanks.

May 23, 2016
hchiorean commented on pull request ModeShape/modeshape#1562
@hchiorean

@RobSis: this cannot be merged because of the following build error: [ERROR] The build could not read 1 project -> [Help 1] [ERROR] [ERROR] The pro…

May 23, 2016
hchiorean commented on pull request ModeShape/modeshape#1562
@hchiorean

@rhauch are you ok with merging this ?

May 20, 2016
hchiorean commented on pull request ModeShape/modeshape#1562
@hchiorean

beside the above, this looks good. @rhauch ?

May 20, 2016
hchiorean commented on pull request ModeShape/modeshape#1562
@hchiorean

@RobSis: again, please rebase it on the latest master and update it. tx

May 20, 2016
@hchiorean
May 20, 2016
hchiorean merged pull request ModeShape/modeshape#1560
@hchiorean
MODE-2551 Adds EPUB 3.0 sequencer
1 commit with 940 additions and 0 deletions
May 19, 2016
@hchiorean
May 19, 2016
hchiorean merged pull request ModeShape/modeshape#1561
@hchiorean
Initial time expression bug
1 commit with 31 additions and 3 deletions
May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1561
@hchiorean

looks good, thanks for the fix. Can you pls squash the commits and force update this PR

May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1560
May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1560
@hchiorean

actually I missed this: you're ignoring the result of the toArray method which is what you really want. So the correct code would be node.setProper…

May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1560
@hchiorean

looks good @rhauch ?

May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1560
@hchiorean

this is not required; the ByteArrayOutputStream#flush method is empty anyway. Writing to a ByteArrayOutputStream is done immediately

May 19, 2016
hchiorean commented on pull request ModeShape/modeshape#1560
@hchiorean

this is not required; that's the whole purpose of try-with-resources

Something went wrong with that request. Please try again.