Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTFul Route added #38

Merged
merged 11 commits into from Dec 21, 2019
Merged

RESTFul Route added #38

merged 11 commits into from Dec 21, 2019

Conversation

@psy2848048
Copy link
Contributor

psy2848048 commented Dec 13, 2019

  • Worked for balance query, transfer, bond, unbond.
  • Temporarily, WASM binary comes from fixed path, will be revised after WASM storage feature is added.
  • Run CLI tests if exists, but exclude from Codecov statistics (Regex doesn't work properly in grep -v)
psy2848048 added 2 commits Dec 12, 2019
- Seprated logic and handler code
@psy2848048 psy2848048 requested a review from hdac-io/developers Dec 13, 2019
@psy2848048 psy2848048 self-assigned this Dec 13, 2019
@psy2848048 psy2848048 force-pushed the features/restapi branch from 8b9acba to 71904aa Dec 13, 2019
@jhyeom26

This comment has been minimized.

Copy link
Collaborator

jhyeom26 commented Dec 13, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.05%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   50.74%   50.68%   -0.06%     
==========================================
  Files         318      319       +1     
  Lines       19896    19989      +93     
==========================================
+ Hits        10096    10132      +36     
- Misses       9081     9128      +47     
- Partials      719      729      +10
Impacted Files Coverage Δ
x/executionlayer/client/rest/rest.go 38.7% <39.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d357e4...71904aa. Read the comment docs.

@psy2848048 psy2848048 changed the title RESTFul Route added WIP: RESTFul Route added Dec 13, 2019
@psy2848048 psy2848048 force-pushed the features/restapi branch from e815a61 to 1d761f5 Dec 13, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.09%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   50.74%   50.84%   +0.09%     
==========================================
  Files         318      317       -1     
  Lines       19896    19731     -165     
==========================================
- Hits        10096    10032      -64     
+ Misses       9081     8979     -102     
- Partials      719      720       +1
Impacted Files Coverage Δ
x/executionlayer/client/rest/msgCreator.go 64.28% <64.28%> (ø)
types/rest/rest.go
x/auth/client/utils/rest.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d357e4...1d761f5. Read the comment docs.

@psy2848048 psy2848048 changed the title WIP: RESTFul Route added RESTFul Route added Dec 13, 2019
@psy2848048 psy2848048 force-pushed the features/restapi branch from 1d761f5 to c5e79b0 Dec 13, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #38 into master will increase coverage by 4.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   50.74%   54.79%   +4.05%     
==========================================
  Files         318      303      -15     
  Lines       19896    18168    -1728     
==========================================
- Hits        10096     9955     -141     
+ Misses       9081     7506    -1575     
+ Partials      719      707      -12
Impacted Files Coverage Δ
x/executionlayer/module.go 0% <0%> (ø) ⬆️
x/genutil/client/cli/gentx.go
x/distribution/client/cli/tx.go
x/staking/client/cli/utils.go
x/genutil/client/cli/migrate.go
x/distribution/client/cli/utils.go
x/gov/client/cli/parse.go
x/staking/client/cli/flags.go
x/gov/client/cli/tx.go
x/genutil/client/cli/validate_genesis.go
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d357e4...9d9fe81. Read the comment docs.

@psy2848048 psy2848048 force-pushed the features/restapi branch 2 times, most recently from 11a2aa5 to 5863472 Dec 13, 2019
- Code separation rest handler & message creation
- Check code coverage for only message creation
- Skip coverage state in rest handler
@psy2848048 psy2848048 force-pushed the features/restapi branch from 5863472 to 8802808 Dec 13, 2019
- Remove 'base_req' and make higher hierarchy
@yoosah
yoosah approved these changes Dec 19, 2019
Copy link
Collaborator

yoosah left a comment

nice

@psy2848048 psy2848048 changed the title RESTFul Route added WIP: RESTFul Route added Dec 21, 2019
@psy2848048

This comment has been minimized.

Copy link
Contributor Author

psy2848048 commented Dec 21, 2019

Balance querying malfunctions.. WIP

@psy2848048 psy2848048 changed the title WIP: RESTFul Route added RESTFul Route added Dec 21, 2019
@psy2848048

This comment has been minimized.

Copy link
Contributor Author

psy2848048 commented Dec 21, 2019

The malfunction is fixed by the PR #39

scripts/tests_with_cover.sh Outdated Show resolved Hide resolved
scripts/tests_with_cover.sh Outdated Show resolved Hide resolved
Copy link
Contributor

JoowonYun left a comment

I added to convert logic

Copy link
Contributor Author

psy2848048 left a comment

@JoowonYun Plz check it

@psy2848048 psy2848048 merged commit 478e5df into master Dec 21, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 0% of diff hit (target 50.74%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/project 54.79% (+4.05%) compared to 7d357e4
Details
@psy2848048 psy2848048 deleted the features/restapi branch Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.