Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load-chainspec overwrites accounts #39

Merged
merged 2 commits into from Dec 22, 2019
Merged

fix: load-chainspec overwrites accounts #39

merged 2 commits into from Dec 22, 2019

Conversation

@jhyeom26
Copy link
Collaborator

jhyeom26 commented Dec 19, 2019

if load-chainspec is executed after add-el-genesis-account, load-chainspec cmd would overwrite accounts with null in executionlayer in genesis.json.

fix the problem by separating Accounts from GenesisConf.

@jhyeom26 jhyeom26 requested a review from hdac-io/developers Dec 19, 2019
@jhyeom26 jhyeom26 self-assigned this Dec 19, 2019
if load-chainspec is executed after add-el-genesis-account,
load-chainspec cmd would overwritten accounts with null
in executionlayer in genesis.json.
fix the problem by separating Accounts from GenesisConf.
@jhyeom26 jhyeom26 force-pushed the private/joonho branch from 8caeeb1 to 588917b Dec 20, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #39 into master will increase coverage by 0.09%.
The diff coverage is 76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   50.74%   50.83%   +0.09%     
==========================================
  Files         318      318              
  Lines       19896    19911      +15     
==========================================
+ Hits        10096    10122      +26     
+ Misses       9081     9070      -11     
  Partials      719      719
Impacted Files Coverage Δ
x/executionlayer/genesis.go 0% <0%> (ø) ⬆️
x/executionlayer/keeper.go 56.91% <100%> (+14.7%) ⬆️
x/executionlayer/types/genesis.go 70% <62.5%> (ø) ⬆️
x/mock/app.go 60.5% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004d9aa...18ec61b. Read the comment docs.

@psy2848048 psy2848048 mentioned this pull request Dec 21, 2019
Copy link
Contributor

psy2848048 left a comment

One critical line :)

cmd/nodef/genesiscmd.go Outdated Show resolved Hide resolved
if users try to insert address already existing,
add-el-genesis-account cmd will return error.
@jhyeom26 jhyeom26 force-pushed the private/joonho branch from 588917b to 18ec61b Dec 21, 2019
Copy link
Contributor

psy2848048 left a comment

LGTM

@jhyeom26 jhyeom26 merged commit 47a7aee into master Dec 22, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch 76% of diff hit (target 50.74%)
Details
codecov/project 50.83% (+0.09%) compared to 7d357e4
Details
@jhyeom26 jhyeom26 deleted the private/joonho branch Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.