Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use incompatible v2021 tbb and tbb-devel packages #90

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

ajelinski
Copy link
Contributor

Related issue: #84

The tbb-2021 and tbb-devel-2021 available on conda-forge aren't
backward compatible. In fact, they will never be backward compatible
again: https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html

The tbb-2021 can't be used to run a package built with tbb-2020
because it even has a main library renamed from libtbb.so.2 to
libtbb.so.12.

The new packages can't be currently built with TBBv2021 because CMake
isn't able to find it. It seems include/tbb/tbb_stddef.h is used
during the lookup but that file has been removed from tbb-devel
package. Also, currently v2021 is only available from conda-forge.

@ajelinski
Copy link
Contributor Author

This PR should make master green again.

@ajelinski
Copy link
Contributor Author

ajelinski commented Mar 9, 2021

I see there's additional problem with antmicro-yosys-plugins that won't make master green. Added an issue #91 and a commit to skip these builds until the issue is solved.

Unfortunately I've also noticed tha skipping metapackage builds when ANACONDA_TOKEN isn't available: 9fd2473 isn't working properly because these builds were skipped on master CI too. I used some other, even better if it's correct, option to skip these builds in cross-repository PRs.

@umarcor do you think this will work as expected now? 3b7bf20

@ajelinski
Copy link
Contributor Author

quicklogic-yosys-osx build had some random error so it seems merging this PR can finally fix the CI on master.

2021-03-10T07:16:38.1358020Z + wget -c https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
2021-03-10T07:16:38.2927870Z --2021-03-10 07:16:38--  https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
2021-03-10T07:17:08.3155200Z Resolving repo.continuum.io (repo.continuum.io)... failed: nodename nor servname provided, or not known.
2021-03-10T07:17:08.3166490Z wget: unable to resolve host address ‘repo.continuum.io’

Related issue: #84

The `tbb-2021` and `tbb-devel-2021` available on `conda-forge` aren't
backward compatible. In fact, they will never be backward compatible
again: https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html

The `tbb-2021` can't be used to run a package built with `tbb-2020`
because it even has a main library renamed from `libtbb.so.2` to
`libtbb.so.12`.

The new packages can't be currently built with TBBv2021 because CMake
isn't able to find it. It seems `include/tbb/tbb_stddef.h` is used
during the lookup but that file has been removed from `tbb-devel`
package. Also, currently `v2021` is only available from `conda-forge`.
This commit can be reversed once #91 is fixed.
@ajelinski
Copy link
Contributor Author

ajelinski commented Mar 10, 2021

I've tested whether the job skipping in cross-repository PRs works properly now and it does: #93 . Since jobs with that addition were successfully run here, i.e., in intra-repository PR, it seems that building is indeed skipped only if there's no ANACONDA_TOKEN.

I'll rebase the PR and merge if green. There was a PR merged in the meantime that seemed to solve antmicro-yosys-plugins but it only worked because it used antmicro-yosys from Anaconda. Therefore the commit disabling that build is left intact.

@PiotrZierhoffer
Copy link
Contributor

Looks fine. We'll address the failing packages separately, but we need the CI green

@PiotrZierhoffer PiotrZierhoffer merged commit 39e7505 into master Mar 10, 2021
@PiotrZierhoffer PiotrZierhoffer deleted the aj-test-tbb-fix branch March 10, 2021 19:43
@@ -34,9 +34,11 @@ requirements:
- xorg-libxcb
- xorg-libxext
- xorg-libxft
- tbb
- tbb-devel
- tbb <2021.0.0a0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it will eventually bite us if another package requires the new version of tbb? Why can the new package not but used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants