-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use incompatible v2021 tbb
and tbb-devel
packages
#90
Conversation
This PR should make master green again. |
I see there's additional problem with Unfortunately I've also noticed tha skipping metapackage builds when @umarcor do you think this will work as expected now? 3b7bf20 |
c90de43
to
3b7bf20
Compare
|
Related issue: #84 The `tbb-2021` and `tbb-devel-2021` available on `conda-forge` aren't backward compatible. In fact, they will never be backward compatible again: https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html The `tbb-2021` can't be used to run a package built with `tbb-2020` because it even has a main library renamed from `libtbb.so.2` to `libtbb.so.12`. The new packages can't be currently built with TBBv2021 because CMake isn't able to find it. It seems `include/tbb/tbb_stddef.h` is used during the lookup but that file has been removed from `tbb-devel` package. Also, currently `v2021` is only available from `conda-forge`.
This commit can be reversed once #91 is fixed.
I've tested whether the job skipping in cross-repository PRs works properly now and it does: #93 . Since jobs with that addition were successfully run here, i.e., in intra-repository PR, it seems that building is indeed skipped only if there's no I'll rebase the PR and merge if green. There was a PR merged in the meantime that seemed to solve |
3b7bf20
to
5d5861c
Compare
Looks fine. We'll address the failing packages separately, but we need the CI green |
@@ -34,9 +34,11 @@ requirements: | |||
- xorg-libxcb | |||
- xorg-libxext | |||
- xorg-libxft | |||
- tbb | |||
- tbb-devel | |||
- tbb <2021.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it will eventually bite us if another package requires the new version of tbb? Why can the new package not but used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to be something like https://docs.conda.io/projects/conda-build/en/latest/resources/variants.html#pinning-at-the-recipe-level (e.g. pin_compatible
)
Related issue: #84
The
tbb-2021
andtbb-devel-2021
available onconda-forge
aren'tbackward compatible. In fact, they will never be backward compatible
again: https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html
The
tbb-2021
can't be used to run a package built withtbb-2020
because it even has a main library renamed from
libtbb.so.2
tolibtbb.so.12
.The new packages can't be currently built with TBBv2021 because CMake
isn't able to find it. It seems
include/tbb/tbb_stddef.h
is usedduring the lookup but that file has been removed from
tbb-devel
package. Also, currently
v2021
is only available fromconda-forge
.