Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements, drop Python 2.7 support #126

Merged
merged 8 commits into from Aug 6, 2019

Conversation

@rly
Copy link
Contributor

rly commented Aug 1, 2019

This PR:

  • drops continuous integration testing for Python 2.7
  • updates documentation
  • updates pinned versions of required packages
  • update GitHub template for bug reports
@rly rly added this to the HDMF 1.2 milestone Aug 1, 2019
@rly

This comment has been minimized.

Copy link
Contributor Author

rly commented Aug 1, 2019

The required GitHub check for CircleCI Python 2.7 will be removed when this is ready to merge.

@oruebel

This comment has been minimized.

Copy link
Contributor

oruebel commented Aug 1, 2019

When dropping Python 3 support on PyNWB, please update the last question on https://neurodatawithoutborders.github.io/faq accordingly

@rly rly requested a review from ajtritt Aug 1, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

16 similar comments
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #126      +/-   ##
=========================================
- Coverage   68.7%   68.42%   -0.29%     
=========================================
  Files         24       24              
  Lines       4960     4959       -1     
  Branches    1128     1127       -1     
=========================================
- Hits        3408     3393      -15     
- Misses      1192     1202      +10     
- Partials     360      364       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.47% <0%> (-0.93%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 60.09% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566d7d5...29acab8. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #126 into dev will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #126      +/-   ##
==========================================
- Coverage   68.67%   68.38%   -0.29%     
==========================================
  Files          24       24              
  Lines        4958     4957       -1     
  Branches     1126     1125       -1     
==========================================
- Hits         3405     3390      -15     
- Misses       1191     1201      +10     
- Partials      362      366       +4
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 59.06% <0%> (-1.17%) ⬇️
src/hdmf/utils.py 88.3% <0%> (-0.92%) ⬇️
src/hdmf/data_utils.py 78.92% <0%> (-0.77%) ⬇️
src/hdmf/build/builders.py 84.69% <0%> (-0.72%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 62.84% <0%> (-0.37%) ⬇️
src/hdmf/build/map.py 59.94% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68003ce...1d5be46. Read the comment docs.

@rly rly requested a review from oruebel Aug 5, 2019
@oruebel

This comment has been minimized.

Copy link
Contributor

oruebel commented Aug 5, 2019

@ajtritt can you review

@ajtritt
ajtritt approved these changes Aug 6, 2019
@rly rly merged commit b14e064 into dev Aug 6, 2019
14 checks passed
14 checks passed
Travis CI - Pull Request Build Passed
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: gallery35 Your tests passed on CircleCI!
Details
ci/circleci: gallery36 Your tests passed on CircleCI!
Details
ci/circleci: gallery37 Your tests passed on CircleCI!
Details
ci/circleci: miniconda35 Your tests passed on CircleCI!
Details
ci/circleci: miniconda36 Your tests passed on CircleCI!
Details
ci/circleci: miniconda37 Your tests passed on CircleCI!
Details
ci/circleci: python35 Your tests passed on CircleCI!
Details
ci/circleci: python36 Your tests passed on CircleCI!
Details
ci/circleci: python37 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 68003ce...1d5be46
Details
codecov/project 68.38% (-0.29%) compared to 68003ce
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rly rly deleted the update_reqs branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.