Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with empty @param #22

Closed
wants to merge 1 commit into from
Closed

Fix crash with empty @param #22

wants to merge 1 commit into from

Conversation

totph
Copy link

@totph totph commented Aug 15, 2022

Clang 14 crashes if getParamNameAsWritten() is called without
first checking whether it exists.

@hdoc
Copy link
Owner

hdoc commented Aug 15, 2022

Hello. Thank you for your contribution! Also, thank you for adding unit tests for your contribution. Both are much appreciated. Good catch on the error too, this is something we clearly missed locally.

We will need you to sign a Contributor Assignment Agreement (CAA) and email it to cla@hdoc.io so that this can be merged into our repository. This is unfortunately necessary for legal reasons. I have attached the CAA to this comment.

Thank you!

hdoc-individual-caa.pdf

Clang 14 crashes if getParamNameAsWritten() is called without
first checking whether it exists.
@hdoc
Copy link
Owner

hdoc commented Aug 17, 2022

Thank you for completing the CLA promptly and sending it over. We have received it. Your changes will be merged in to our upstream hdoc repo (which is private) and when we make a new release the changes will be reflected on GitHub. We’re targeting this changes for hdoc 1.3.1, which is the next release.

Thank you for finding and fixing this bug and submitting a good PR, even with unit tests! We will credit you in the release notes for the next release. Thank you and have a good week.

@hdoc hdoc closed this Aug 17, 2022
@hdoc
Copy link
Owner

hdoc commented Sep 30, 2022

Hello @totph, your fix has been incorporated in hdoc 1.3.1 which we just released. We have credited you in the release notes, which can be found here: https://hdoc.io/release-notes/#version-1-3-1-29-september-2022. In addition, we've credited you for the variety of suggestions and bugs you've reported recently.

Thank you for your invaluable feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants