Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping guardrail #4

Open
wants to merge 5 commits into
base: master
from

Conversation

@blast-hardcheese
Copy link

blast-hardcheese commented Nov 3, 2019

Setting version to 0.54.2

@blast-hardcheese

This comment has been minimized.

Copy link
Author

blast-hardcheese commented Nov 3, 2019

Pretty sure there are some other changes required with this, running tests locally.

@blast-hardcheese

This comment has been minimized.

Copy link
Author

blast-hardcheese commented Nov 3, 2019

So, on review of how generation current works:

  • language must come first in the argument list, as that fundamentally changes how arguments are parsed
  • Added customImports mapping to --import
  • Added modules (? please review to ensure there's no configuration missing), mapping to --module
  • Java codegen doesn't currently support nested enum literals. As a result, I altered the test spec to use $ref to define a literal enum type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.