Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting and completion to repl #106

Merged
merged 13 commits into from Sep 6, 2020

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Sep 5, 2020

image

@bjorn3 bjorn3 requested a review from nbaksalyar Sep 5, 2020
@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 5, 2020

Would it make sense to move repl_tools to a separate repo, as it can be useful for other projects too?

examples/repl.rs Show resolved Hide resolved
examples/repl.rs Show resolved Hide resolved
@blitzerr
Copy link
Contributor

blitzerr commented Sep 5, 2020

Good one @bjorn3 !

@blitzerr blitzerr mentioned this pull request Sep 5, 2020
Copy link
Member

@nbaksalyar nbaksalyar left a comment

This looks great, thanks! I left a few comments.

Re publishing repl_tools - that's an excellent idea. What's your preference here @bjorn3 - do you want to create a repository under the headcrab-rs organisation or have it under your username? Or would it be easier to just have it in-tree in this repo for now?

Ok(()) => {}
Err(err) => {
println!("\x1b[91mError: {}\x1b[0m", err);
if color.get() {
println!("\x1b[91mError: {}\x1b[0m", err);
Copy link
Member

@nbaksalyar nbaksalyar Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a dev-dependency like ansi_term to specify colours?

Copy link
Contributor Author

@bjorn3 bjorn3 Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansi_term doesn't have a method for the bright variants of colors: ogham/rust-ansi-term#66

src/target/linux.rs Outdated Show resolved Hide resolved
repl_tools/src/lib.rs Outdated Show resolved Hide resolved
@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 6, 2020

I think repl_tools can stay in tree for now. There may be multiple breaking changes in the near future. Once it becomes more stable, it can move to a separate repo as part of headcrab-rs.

Copy link
Member

@nbaksalyar nbaksalyar left a comment

Thank you!

@bjorn3 bjorn3 merged commit 10f006f into headcrab-rs:master Sep 6, 2020
@bjorn3 bjorn3 deleted the repl_improvements branch Sep 6, 2020
FlyingCanoe pushed a commit to FlyingCanoe/headcrab that referenced this pull request Jul 25, 2021
headcrab-rs#106 is hit if object and addr2line are added to Cargo.toml where object version does not match the version addr2line depends on. addr2line re-exports the correct version, which is now referred to instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants