Add syntax highlighting and completion to repl #106
Conversation
bjorn3
commented
Sep 5, 2020
bjorn3
commented
|
Would it make sense to move |
|
Good one @bjorn3 ! |
There was a problem hiding this comment.
This looks great, thanks! I left a few comments.
Re publishing repl_tools - that's an excellent idea. What's your preference here @bjorn3 - do you want to create a repository under the headcrab-rs organisation or have it under your username? Or would it be easier to just have it in-tree in this repo for now?
| Ok(()) => {} | ||
| Err(err) => { | ||
| println!("\x1b[91mError: {}\x1b[0m", err); | ||
| if color.get() { | ||
| println!("\x1b[91mError: {}\x1b[0m", err); |
There was a problem hiding this comment.
Maybe use a dev-dependency like ansi_term to specify colours?
There was a problem hiding this comment.
ansi_term doesn't have a method for the bright variants of colors: ogham/rust-ansi-term#66
|
I think |
headcrab-rs#106 is hit if object and addr2line are added to Cargo.toml where object version does not match the version addr2line depends on. addr2line re-exports the correct version, which is now referred to instead.
