Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgui based gui example #114

Merged
merged 12 commits into from Sep 27, 2020
Merged

Add imgui based gui example #114

merged 12 commits into from Sep 27, 2020

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Sep 24, 2020

image

It looks much better with a ttf font instead of the builtin imgui font, but I will leave that for a future PR.

Copy link
Member

@nbaksalyar nbaksalyar left a comment

Looks great, thanks! Would you also like to add the font files?

macOS CI run fails with the remote end hung up unexpectedly which seems like a problem on the Travis's end. My vote is for ignoring this temporarily - there will be more PRs dealing with missing features for macOS anyway.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 25, 2020

I will add a font tomorrow. The travis issue looks like a temporary network outage.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 26, 2020

image

New screenshot with FiraMono (171KiB file) as font.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 26, 2020

---- target::linux::writemem::tests::write_memory_ptrace stdout ----

thread 'target::linux::writemem::tests::write_memory_ptrace' panicked at 'called `Result::unwrap()` on an `Err` value: Sys(EPERM)', src/target/linux/writemem.rs:292:91

I didn't change any of the relevant code, but there also doesn't seem to be a race-condition.

@nbaksalyar
Copy link
Member

nbaksalyar commented Sep 27, 2020

This seems like a bug in the ptrace tests. I will create a separate issue to tackle it, and I restarted the CI - let's see if it shows up consitently.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 27, 2020

Happened again.

@nbaksalyar
Copy link
Member

nbaksalyar commented Sep 27, 2020

And now it's passed. I created #116 and will investigate it as a separate issue.
Merging this PR now.

Thanks!

@nbaksalyar nbaksalyar merged commit dff82e4 into headcrab-rs:master Sep 27, 2020
@bjorn3 bjorn3 deleted the imgui branch Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants