Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out code common for all *nix platform #28

Merged
merged 10 commits into from Jul 24, 2020
Merged

Split out code common for all *nix platform #28

merged 10 commits into from Jul 24, 2020

Conversation

DeltaManiac
Copy link
Collaborator

@DeltaManiac DeltaManiac commented Jul 23, 2020 •
edited

Hi @nbaksalyar

Fixes #9

Changes

  • Moved the common code from linux to unix module
  • Added cirrus.yml to test for BSD (cargo build and cargo test) on Cirrus CI and it passes for FreeBSD12

Pending Tasks

  • Clean the commented code
  • Improve the doc Comments
  • Add Cirrus badge to ReadMe.md

DeltaManiac
DeltaManiac commented Jul 23, 2020
View reviewed changes
tests/readmem.rs Outdated Show resolved Hide resolved
nbaksalyar
nbaksalyar reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@nbaksalyar nbaksalyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! I left a small comment about pid.

tests/readmem.rs Outdated Show resolved Hide resolved
nbaksalyar
nbaksalyar reviewed Jul 23, 2020
View reviewed changes
src/target/unix.rs Outdated Show resolved Hide resolved
nbaksalyar
nbaksalyar reviewed Jul 24, 2020
View reviewed changes
src/target/linux.rs Outdated Show resolved Hide resolved
nbaksalyar
nbaksalyar approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@nbaksalyar nbaksalyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nbaksalyar nbaksalyar merged commit 57c81d7 into headcrab-rs:master Jul 24, 2020
1 check passed
@DeltaManiac DeltaManiac mentioned this pull request Jul 24, 2020
Closed
@DeltaManiac DeltaManiac deleted the unix branch August 13, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaksalyar nbaksalyar nbaksalyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split out code common for all *nix from the Linux target module
2 participants
@DeltaManiac @nbaksalyar