Resolve symbols #46
Resolve symbols #46
Conversation
src/lib.rs
Outdated
| @@ -1,5 +1,8 @@ | |||
| //! Headcrab, a modern Rust debugging library. | |||
|
|
|||
| #[macro_use] | |||
| extern crate rental; | |||
There was a problem hiding this comment.
This crate seems to be archived & not maintained anymore and the author recommends to explore other solutions: https://github.com/jpernst/rental
As it seems, in this PR it's only used for safe borrowing of Mmap - I wonder if we can do the same with contained unsafe code? What do you think?
There was a problem hiding this comment.
I didn't know it was archived.
There was a problem hiding this comment.
I have extracted the actual debuginfo parsing into ParsedDwarf::new keeping Dwarf::new as a thin wrapper that only handles the self-referential part. I have also written some unsafe code as replacement for rental. I am currently waiting on a review over at the t-lang/wg-unsafe-code-guidelines stream of the rust-lang zulip.
There was a problem hiding this comment.
Thank you!
some unsafe code as replacement for rental
This can be submitted as a separate issue/PR, if it would be easier for you.
I'm going to review the rest of the code now.
There was a problem hiding this comment.
I got a review, so I pushed it.
| @@ -9,7 +9,7 @@ static BIN_PATH: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/tests/testees/hell | |||
|
|
|||
| #[cfg(all(target_os = "linux", target_arch = "x86_64"))] | |||
| #[test] | |||
| fn read_memory() -> Result<(), Box<dyn std::error::Error>> { | |||
| fn read_regs() -> Result<(), Box<dyn std::error::Error>> { | |||
Fixes #44
Based on #34