Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More execution commands and use waitpid where sensible #58

merged 2 commits into from Jul 29, 2020


Copy link

@bjorn3 bjorn3 commented Jul 28, 2020

While there are legitimate use cases where waitpid should not be used, not using it will in most cases lead to race-conditions between stopping execution of the debuggee again and reading/writing state.

Copy link

@nbaksalyar nbaksalyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you! Just a very minor nitpick. :)

src/target/ Outdated Show resolved Hide resolved
Co-authored-by: Nikita Baksalyar <>
@nbaksalyar nbaksalyar merged commit 53d1867 into headcrab-rs:master Jul 29, 2020
1 check passed
@bjorn3 bjorn3 deleted the step_and_wait branch July 29, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants