More execution commands and use waitpid where sensible - #58
Merged
Merged
Conversation
nbaksalyar
reviewed
Jul 29, 2020
nbaksalyar
left a comment
nbaksalyar
left a comment
Member
There was a problem hiding this comment.
Looking great, thank you! Just a very minor nitpick. :)
nbaksalyar
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there are legitimate use cases where waitpid should not be used, not using it will in most cases lead to race-conditions between stopping execution of the debuggee again and reading/writing state.