Naive and frame pointer stack unwinders - #61
Merged
Conversation
nbaksalyar
reviewed
Aug 4, 2020
nbaksalyar
left a comment
Member
There was a problem hiding this comment.
Hey, sorry for a delay with the review - this is very cool, thanks! I left a few general comments and suggestions, and this can be merged after the merge conflict is resolved.
Later we can also integrate this with rustc-demangle to have a quick win with getting real function names. I'll create a new issue for that.
nbaksalyar
approved these changes
Aug 4, 2020
nbaksalyar
left a comment
Member
There was a problem hiding this comment.
LGTM! 馃憤 Merge seems to be blocked by a conflict though, could you please take a look at it?
Co-authored-by: Nikita Baksalyar <nikita.baksalyar@gmail.com>
bjorn3
force-pushed
the
unwind_the_stack
branch
from
August 4, 2020 08:36
ee57cca to
0c71b2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naive unwinder scans the stack for words that could be function pointers, while the frame pointer unwinder uses the frame pointer linked list.
cc #60