Kill debugee on debugger exit #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaksalyar
approved these changes
Jul 30, 2020
| @@ -141,6 +143,12 @@ impl LinuxTarget { | |||
| }) | |||
| .collect()) | |||
| } | |||
|
|
|||
| /// Kill debuggee when debugger exits. | |||
| fn kill_on_exit(&self) -> Result<(), Box<dyn std::error::Error>> { | |||
There was a problem hiding this comment.
I think this can be a pub fn for the case when a user wants to use this option after attach, but it's unclear whether this should be a function call, or a configuration parameter like target.attach(pid, Config { kill_on_exit: true, ... }). Let's leave it as it is now & create an issue for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #48. If debugee was launched by debugger it is killed when debugger exits.