-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol demangling #74
Conversation
There's definitely something not working. Please dont merge |
Thanks, this is great! I think we can also change the list of expected names in tests/unwind_stack.rs to verify the demangling routines work correctly. Do you want to do this as a part of this pull request? |
Yes that's how I saw that my code is broken |
I just remembered that Directly using |
tests/unwind_stack.rs
Outdated
"_ZN3std2rt19lang_start_internal17h", | ||
"hello::main::", | ||
"std::rt::lang_start::{{closure}}::", | ||
"std::rt::lang_start_internal::", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think get_address_symbol_name
should not demangle the name. Instead there could be an extra method get_address_demangled_name
.
Yeah, it also seems to be automatically choosing between the C++ & Rust mangling schemes depending on DWARF lang param, which is a nice feature if we want to support more langs in the future. So we can probably use addr2line as the default demangling function and resort to the direct |
That sounds good. Should I wait for #54 or add it here as well? |
Please wait, it conflicts with #54. |
#54 is merged now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Can you change Line 230 in 25b85b7
|
Thank you! |
I'm not sure if this is the approach you wanted, but I think this should work.
Resolves #71