Symbol demangling

[Stupremee]

I'm not sure if this is the approach you wanted, but I think this should work.

Resolves #71

[Stupremee]

There's definitely something not working. Please dont merge

[nbaksalyar]

Thanks, this is great! I think we can also change the list of expected names in tests/unwind_stack.rs to verify the demangling routines work correctly. Do you want to do this as a part of this pull request?

[Stupremee]

Yes that's how I saw that my code is broken

[bjorn3]

I just remembered that addr2line already has demangling support. This also handles inlined functions. https://docs.rs/addr2line/0.13.0/addr2line/struct.FunctionName.html#method.demangle

Directly using rustc-demangle is useful for when there is no DWARF debuginfo though.

[bjorn3]

I think get_address_symbol_name should not demangle the name. Instead there could be an extra method get_address_demangled_name.

[nbaksalyar]

addr2line already has demangling support

Yeah, it also seems to be automatically choosing between the C++ & Rust mangling schemes depending on DWARF lang param, which is a nice feature if we want to support more langs in the future. So we can probably use addr2line as the default demangling function and resort to the direct rustc-demangle when there's no DWARF available?

[Stupremee]

I just remembered that addr2line already has demangling support.

That sounds good. Should I wait for #54 or add it here as well?

[bjorn3]

Please wait, it conflicts with #54.

[nbaksalyar]

#54 is merged now 👍

[nbaksalyar]

Thank you!

[bjorn3]

Can you change

headcrab/examples/repl.rs

Line 230 in 25b85b7

.get_address_symbol_name(func)

to use the demangled name?

[nbaksalyar]

Thank you!