ReadMem improvements #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use proc_vm_write and proc_vm_read on protected memory pages, so we should split memory operations into the ones that can be applied to protected pages (using ptrace) and the ones which can use more efficient operations (proc_vm_*). This commit changes read-specific function to a generic function that can be used for writes too.
These functions can be used for reading vectors and arrays from debuggee's memory. This commit also refactors the readmem tests: `PAGE_SIZE` value is taken from lazily-initialized static instead of a constant, and the pointer arithmetic code is changed to use functions from `std::ptr` for more clarity.
bjorn3
requested changes
Aug 7, 2020
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Emphasise its usage for both read and write operations and document the `maps` argument.
- Add a new method to read a u8 slice from debuggee's memory. - `ReadOp::split_on_page_boundary` takes the output var as a mutable reference instead of allocating a new vector.
bjorn3
requested changes
Aug 7, 2020
- Get rid of unnecessary cloning (iter.cloned() -> into_iter()) - Rename function parameter for clarity (maps -> protected_maps) - Make ReadMem::read_process_vm and ReadMem::read_ptrace associated functions
bjorn3
approved these changes
Aug 7, 2020
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks some improvements from #41 (to leave it write-specific and more manageable to review).
It also introduces new methods,
ReadMem::read_sliceandReadMem::read_ptr, which can be used for reading vectors and arrays from debuggee's memory.