Make threads test more robust #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can handle the failure to obtain the name of a thread. This might happen for different reaons (e.g., maybe the thread is not there anymore). I'm keeping the error as the name to show in the assertions failures.
bjorn3
reviewed
Aug 10, 2020
|
Seems the test instance got re-scheduled |
bjorn3
reviewed
Aug 13, 2020
Should be safe to unwrap, the name method already handles threads that have finished by returning None. So Err() results would have to be some sort of bug.
Prevents an allocation in the happy case. Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Can handle the failure to obtain the name of a thread. This might
happen for different reasons (e.g., maybe the thread is not there
anymore). I'm keeping the error as the name to show in the assertions
failures.