-
-
Notifications
You must be signed in to change notification settings - Fork 31
Show local values #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bjorn3
commented
Aug 14, 2020
Ignore all frames below main. This is necessary to make the next commit pass tests.
It is handcoded to prevent printing the whole underlying blob of debuginfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you! The repl example is starting to feel like a real thing 🎉
I left one minor comment about Frame::print_debuginfo
, but since this PR is already huge, I think it's better to merge it sooner and address details afterwards.
} | ||
|
||
pub fn print_debuginfo(&self) { | ||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later, we probably can replace this with impl<'a> fmt::Display for Frame<'a>
, then it can be printed/formatted into a string.