Show local values - #84
Merged
Merged
Conversation
bjorn3
commented
Aug 14, 2020
Contributor
Ignore all frames below main. This is necessary to make the next commit pass tests.
It is handcoded to prevent printing the whole underlying blob of debuginfo
nbaksalyar
approved these changes
Aug 15, 2020
nbaksalyar
left a comment
Member
There was a problem hiding this comment.
This is awesome, thank you! The repl example is starting to feel like a real thing 馃帀
I left one minor comment about Frame::print_debuginfo, but since this PR is already huge, I think it's better to merge it sooner and address details afterwards.
| } | ||
|
|
||
| pub fn print_debuginfo(&self) { | ||
| println!( |
Member
There was a problem hiding this comment.
Later, we probably can replace this with impl<'a> fmt::Display for Frame<'a>, then it can be printed/formatted into a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.