Get a thread list from an OSX task - #85
Merged
Merged
Conversation
added 2 commits
August 16, 2020 16:30
- Using the thread port as the id because we will need it to control the thread (as in delve [1]). - Most mach threads belong to a pthread from which we can get the name. Couldn't find any other way. This doesn't resolve the main thread name. [1] - https://github.com/go-delve/delve/blob/af250d45126070adbc702fe4ae1b74f19dcfdf97/pkg/proc/native/proc_darwin.go#L260
bjorn3
requested changes
Aug 16, 2020
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
bjorn3
reviewed
Aug 16, 2020
bjorn3
reviewed
Aug 16, 2020
| } | ||
|
|
||
| extern "C" { | ||
| // FIXME: Use libc > 0.2.74 when available |
Contributor
There was a problem hiding this comment.
You mean this will be in the next release of the libc crate?
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
bjorn3
approved these changes
Aug 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
control the thread (as in delve).
Couldn't find any other way. This doesn't resolve the main thread name.