Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -march-i686 not supported in Ubuntu 12.04 LTS #27

Merged
merged 1 commit into from Aug 3, 2013

Conversation

Eric-Guo
Copy link
Contributor

@Eric-Guo Eric-Guo commented Aug 3, 2013

I believe the -march-i686 is outdated switch, see below as reference
http://gcc.gnu.org/onlinedocs/gcc/i386-and-x86_002d64-Options.html

root@eric:/usr/local/rvm/gems/ruby-1.9.3-p392/gems/atomic-1.1.11/ext# cat mkmf.log 
"gcc -o conftest -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1/i686-linux -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1/ruby/backward -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1 -I.  -D_FILE_OFFSET_BITS=64  -I/usr/local/rvm/usr/include  -O3 -ggdb -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializers -Wpointer-arith -Wwrite-strings -Wdeclaration-after-statement -Wimplicit-function-declaration  -fPIC -march-i686 conftest.c  -L. -L/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -Wl,-R/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -L/usr/local/rvm/usr/lib -Wl,-R/usr/local/rvm/usr/lib -L.  -rdynamic -Wl,-export-dynamic -L/usr/local/rvm/usr/lib  -Wl,-R/usr/local/rvm/usr/lib      -Wl,-R -Wl,/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -L/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -lruby  -lpthread -lrt -ldl -lcrypt -lm   -lc"
cc1: error: unrecognized command line option ‘-march-i686’

```
root@eric:/usr/local/rvm/gems/ruby-1.9.3-p392/gems/atomic-1.1.11/ext# cat mkmf.log 
"gcc -o conftest -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1/i686-linux -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1/ruby/backward -I/usr/local/rvm/rubies/ruby-1.9.3-p392/include/ruby-1.9.1 -I.  -D_FILE_OFFSET_BITS=64  -I/usr/local/rvm/usr/include  -O3 -ggdb -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializers -Wpointer-arith -Wwrite-strings -Wdeclaration-after-statement -Wimplicit-function-declaration  -fPIC -march-i686 conftest.c  -L. -L/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -Wl,-R/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -L/usr/local/rvm/usr/lib -Wl,-R/usr/local/rvm/usr/lib -L.  -rdynamic -Wl,-export-dynamic -L/usr/local/rvm/usr/lib  -Wl,-R/usr/local/rvm/usr/lib      -Wl,-R -Wl,/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -L/usr/local/rvm/rubies/ruby-1.9.3-p392/lib -lruby  -lpthread -lrt -ldl -lcrypt -lm   -lc"
cc1: error: unrecognized command line option ‘-march-i686’
```
@headius
Copy link
Owner

headius commented Aug 3, 2013

Sometimes I really hate C :-)

headius added a commit that referenced this pull request Aug 3, 2013
Fix -march-i686 not supported in Ubuntu 12.04 LTS
@headius headius merged commit 585986f into headius:master Aug 3, 2013
@headius
Copy link
Owner

headius commented Aug 3, 2013

I've merged this but I'm going to confirm a few flavors of Linux before I release this time.

@headius
Copy link
Owner

headius commented Aug 3, 2013

I confirmed the gem installs ok on RHEL 32/64 and Ubuntu 32/64 (current versions on AWS). Pushed version 1.1.12.

@headius headius added this to the atomic-1.1.14 and earlier milestone Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants