New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CSS-Router functionality #227

Closed
TriMoon opened this Issue Mar 24, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@TriMoon

TriMoon commented Mar 24, 2013

Please see my comment to the source line of core.js:
48d4823#src-core-js-P231

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 8, 2013

Contributor

Nice catch, it actually fixes a small bug too

When pointing to:
http://localhost/headjs/test/unit/index.html

Before modification:

headjs-section
headjs-test-section
headjs-test-unit-section
headjs-section
headjs-test-section
headjs-test-unit-section

After modification:

headjs-section
test-section
unit-section
headjs-section
headjs-test-section
headjs-test-unit-section

Will be pushing this to master & wip-1.0 asap

Contributor

ghost commented May 8, 2013

Nice catch, it actually fixes a small bug too

When pointing to:
http://localhost/headjs/test/unit/index.html

Before modification:

headjs-section
headjs-test-section
headjs-test-unit-section
headjs-section
headjs-test-section
headjs-test-unit-section

After modification:

headjs-section
test-section
unit-section
headjs-section
headjs-test-section
headjs-test-unit-section

Will be pushing this to master & wip-1.0 asap

@itechnology itechnology closed this May 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment