New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-js class not removed with JavaScript enabled #270

Closed
marcinkrzeminski opened this Issue Nov 12, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@marcinkrzeminski

marcinkrzeminski commented Nov 12, 2013

Hello,

After I udpated to the latest version of HeadJS I noticed that no-js class is visible inside all classes applied to the html tag of my document. I checked headjs.com and it's also there. Please take a look at the attached image.

headjs

@robert-hoffmann

This comment has been minimized.

Show comment
Hide comment
@robert-hoffmann

robert-hoffmann Nov 12, 2013

Member

Investigating ..tracked this to this fix #226

The quick-fix is to insert a space before "no-js ..." like this " no-js ..."

Member

robert-hoffmann commented Nov 12, 2013

Investigating ..tracked this to this fix #226

The quick-fix is to insert a space before "no-js ..." like this " no-js ..."

@marcinkrzeminski

This comment has been minimized.

Show comment
Hide comment
@marcinkrzeminski

marcinkrzeminski Nov 12, 2013

Thanks, another quick fix is to use jQuery for that but I reported this that HeadJS will be even more awesome ;). Do you plan to patch this pretty quick?

marcinkrzeminski commented Nov 12, 2013

Thanks, another quick fix is to use jQuery for that but I reported this that HeadJS will be even more awesome ;). Do you plan to patch this pretty quick?

@robert-hoffmann

This comment has been minimized.

Show comment
Hide comment
@robert-hoffmann

robert-hoffmann Nov 12, 2013

Member

got it fixed for both use-cases, and Chrome. Patch should follow quickly

Member

robert-hoffmann commented Nov 12, 2013

got it fixed for both use-cases, and Chrome. Patch should follow quickly

@marcinkrzeminski

This comment has been minimized.

Show comment
Hide comment
@marcinkrzeminski

marcinkrzeminski Nov 13, 2013

Sweet ;). Many thanks and keep up an awesome job with HeadJS 👍

marcinkrzeminski commented Nov 13, 2013

Sweet ;). Many thanks and keep up an awesome job with HeadJS 👍

@robert-hoffmann

This comment has been minimized.

Show comment
Hide comment
@robert-hoffmann

robert-hoffmann Nov 13, 2013

Member

Your welcome, and thanks for the heads up on the problem 👍

Member

robert-hoffmann commented Nov 13, 2013

Your welcome, and thanks for the heads up on the problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment