New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fix for issue #165 #166

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
@theosp

theosp commented Oct 17, 2011

No description provided.

theosp added some commits Jan 16, 2011

Bugfix: on msie the browser detection feature should check documentMo…
…de to determine version

If the document.documentMode is available, it specify the ie version behavior
in use. In that case the browser version the user-agent specify has no meaning
for the page styling, therefore the version classes should be determined by the
documentMode version.
Merge remote branch 'headjs/dev'
Conflicts:
	src/core.js
Merge branch 'master' of github.com:headjs/headjs
Conflicts:
	dist/head.js
	src/core.js
bugfix: isAsync version of head.js(): don't assume the last method pa…
…ssed to head.js() will load last. fixes #165

Check whether its time to call the callback method for each script that is ready, and not only after the last script is ready.
@cbess

This comment has been minimized.

Show comment
Hide comment
@cbess

cbess Oct 17, 2011

Haha, you think they are going to update this repository with bug fixes?

cbess commented Oct 17, 2011

Haha, you think they are going to update this repository with bug fixes?

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Oct 17, 2011

@cbess i will but i'm asking theosp in #165 to create a unit test first :)

@cbess i will but i'm asking theosp in #165 to create a unit test first :)

@theosp

This comment has been minimized.

Show comment
Hide comment
@theosp

theosp Oct 23, 2011

I don't have the time to write a unittest for it, I hope more people that will face this issue will pull the fix and confirm that it's ok.

theosp commented Oct 23, 2011

I don't have the time to write a unittest for it, I hope more people that will face this issue will pull the fix and confirm that it's ok.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 14, 2012

Contributor

closing since #165 is closed too

Contributor

ghost commented Nov 14, 2012

closing since #165 is closed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment