Update load.js #257

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mschilder
Contributor

Use === to compare with null to prevent IE(8?) to report error. Can you make sure that this improvement is added to all files in the /dist folder as well.

@mschilder mschilder Update load.js
Use === to compare with null to prevent IE(8?) to report error.
d151b82
@itechnology
Contributor

Always wanted to change this to ===, but was never quite sure it really always evaluates to null ..what if some browser evaluates this to undefined ? I think the better way would be to test for !win.frameElement

https://developer.mozilla.org/en-US/docs/Web/API/window.frameElement#Browser_compatibility

example:
undefined == null returns true
undefined === null returns false

@itechnology
Contributor

changed code to !win.frameElement just in case some browser decides to give undefined instead of null

Changes have been pushed to src/dist and .map files are now available for all js files ..cdn has not been updated yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment