New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load.js #257

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mschilder
Contributor

mschilder commented Sep 11, 2013

Use === to compare with null to prevent IE(8?) to report error. Can you make sure that this improvement is added to all files in the /dist folder as well.

Update load.js
Use === to compare with null to prevent IE(8?) to report error.
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 12, 2013

Contributor

Always wanted to change this to ===, but was never quite sure it really always evaluates to null ..what if some browser evaluates this to undefined ? I think the better way would be to test for !win.frameElement

https://developer.mozilla.org/en-US/docs/Web/API/window.frameElement#Browser_compatibility

example:
undefined == null returns true
undefined === null returns false

Contributor

ghost commented Sep 12, 2013

Always wanted to change this to ===, but was never quite sure it really always evaluates to null ..what if some browser evaluates this to undefined ? I think the better way would be to test for !win.frameElement

https://developer.mozilla.org/en-US/docs/Web/API/window.frameElement#Browser_compatibility

example:
undefined == null returns true
undefined === null returns false

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 13, 2013

Contributor

changed code to !win.frameElement just in case some browser decides to give undefined instead of null

Changes have been pushed to src/dist and .map files are now available for all js files ..cdn has not been updated yet

Contributor

ghost commented Sep 13, 2013

changed code to !win.frameElement just in case some browser decides to give undefined instead of null

Changes have been pushed to src/dist and .map files are now available for all js files ..cdn has not been updated yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment