Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mpris #225

Merged
merged 5 commits into from Mar 7, 2019

Conversation

3 participants
@fcastilloec
Copy link
Member

commented Mar 7, 2019

This will update MPRIS to the new version which uses the new dbus-next module. Now we can use the same module for registering media keys.
The new module doesn't need the dbus dependencies for Linux making easier to build. We can now even build a 32bit version from a 64bit machine.
It also fixes my workaround for some properties of MPRIS where I had to add 1e-15

fcastilloec added some commits Mar 6, 2019

Fix old workarounds in MPRIS and add support for more events
Latest version of mpris-service fixed the need to use 1e-15 on some variables
We have also added support for shuffle, repeat, position and seek
Fix MediaKeys with new mpris API
MediaKeys code only works for Mate and older version of gnome
All OSs using gnome3 use MPRIS to send mediakey shortcuts

@fcastilloec fcastilloec requested a review from danielravina Mar 7, 2019

@fcastilloec

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

I've tested in MATE, Gnome, Cinnamon, Gnome3, and Budgie; media keys and all mpris features are working on all of them.

@fcastilloec fcastilloec changed the title WIP: New mpris New mpris Mar 7, 2019

@fcastilloec

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Also, this PR works together with the PR for the core, some of the new MPRIS features will only work with the new core version

@fcastilloec fcastilloec merged commit 3d11862 into master Mar 7, 2019

3 checks passed

WIP Legacy commit status override — see details
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fcastilloec fcastilloec deleted the new-mpris branch Mar 7, 2019

@acrisci

This comment has been minimized.

Copy link

commented Mar 17, 2019

👍 tag me in issues if you need help with the mpris-service stuff in the future.

@@ -96,36 +98,76 @@ module.exports = (win, player, app) => {
}
});

mprisPlayer.on('seek', (seek) => {
if (mprisPlayer.playbackStatus !== 'Stopped') {
if (seek < 0) seek = ~seek;

This comment has been minimized.

Copy link
@fcastilloec

fcastilloec Mar 17, 2019

Author Member

@acrisci this is the only issue we have with mpris-service right now. I've already reported it here: dbusjs/mpris-service#27
We're waiting for the fix to come so I can remove this workaround and probably ship the new version

This comment has been minimized.

Copy link
@acrisci

acrisci Mar 17, 2019

Just waiting on people to approve some other implementations before the release comes with this fix. Should be ready sometime in the next week.

@acrisci acrisci referenced this pull request Mar 18, 2019

Open

Player implementation status #30

7 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.