Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SystemStackError with ActiveRecord #27

Merged
merged 1 commit into from May 12, 2016

Conversation

garethrees
Copy link
Contributor

@garethrees garethrees commented Oct 8, 2015

Fixes #26

If you use the default otp_counter column name, InstanceMethodsOnActivation#otp_counter calls otp_counter resulting in a stack overflow.

ActiveRecord::Schema.define do
self.verbose = false

create_table :activerecord_users, :force => true do |t|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

@garethrees garethrees force-pushed the stack-too-deep branch 2 times, most recently from a2d02ff to 79a7fed Compare Oct 8, 2015
@garethrees
Copy link
Contributor Author

@garethrees garethrees commented Oct 8, 2015

Cleared up some Hound warnings – remaining ones are just following existing conventions.

end
rescue => e
warn "#{$0}: #{e}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

If you use the default `otp_counter` column name,
InstanceMethodsOnActivation#otp_counter calls `otp_counter` resulting in
a stack overflow.
garethrees referenced this issue in mysociety/alaveteli Oct 9, 2015
- Adds forked gem for temporary fix; see commit ref for details
- Regenerates the secret and counter when enabled
@garethrees
Copy link
Contributor Author

@garethrees garethrees commented Oct 26, 2015

Anything I can do to help get this merged? Cheers.

@robertomiranda
Copy link
Member

@robertomiranda robertomiranda commented Oct 26, 2015

@garethrees sorry for the delay, I'm going to take a look today

@garethrees
Copy link
Contributor Author

@garethrees garethrees commented Oct 26, 2015

@robertomiranda thanks, much appreciated! Feel free to get in touch if there's anything you need to clarify :) 🍻

@robertomiranda robertomiranda merged commit c342283 into heapsource:master May 12, 2016
2 checks passed
mysociety-pusher pushed a commit to mysociety/alaveteli that referenced this issue May 17, 2016
@garethrees garethrees deleted the stack-too-deep branch May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants