Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two deprecated usages of keyword arguments. #5174

Merged

Conversation

connorshea
Copy link
Contributor

@connorshea connorshea commented Dec 27, 2019

This prevents us from using behavior that was deprecated in Ruby 2.7.

I was getting these lines in my test suite with Ruby 2.7, this change fixes them:

/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/devise-4.7.1/lib/devise/failure_app.rb:110: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/i18n-1.7.0/lib/i18n.rb:179: warning: The called method `t' is defined here
/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/devise-4.7.1/app/controllers/devise_controller.rb:187: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/i18n-1.7.0/lib/i18n.rb:179: warning: The called method `t' is defined here

See also:

Thanks :)

This prevents us from using behavior that was deprecated in Ruby 2.7.
@sourcelevel-bot
Copy link

sourcelevel-bot bot commented Dec 27, 2019

Hello, @connorshea! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@rafaelfranca rafaelfranca merged commit 83a32e6 into heartcombo:master Dec 27, 2019
2 checks passed
@pedrofurtado
Copy link

pedrofurtado commented Dec 28, 2019

@rafaelfranca In which version this fix will be available? 🤝 😃

@rafaelfranca
Copy link
Collaborator

rafaelfranca commented Dec 28, 2019

The next one. 4.7.2 or 4.8.0 or 5.0.0

@connorshea connorshea deleted the fix-ruby-27-deprecation-warnings branch May 9, 2020
@connorshea
Copy link
Contributor Author

connorshea commented May 9, 2020

@rafaelfranca now that Rails 6.0.3 is out, could we get a new release of devise with this fix? :)

@carlosantoniodasilva
Copy link
Member

carlosantoniodasilva commented Jun 10, 2020

@connorshea v4.7.2 is out with this and other Ruby 2.7 warnings fixed. Thanks!

@connorshea
Copy link
Contributor Author

connorshea commented Jun 10, 2020

@carlosantoniodasilva Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants