Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectionResponder with inflect.uncountable #54

Closed
darkleaf opened this issue Sep 27, 2012 · 10 comments
Closed

CollectionResponder with inflect.uncountable #54

darkleaf opened this issue Sep 27, 2012 · 10 comments

Comments

@darkleaf
Copy link

I have:

  • resources :news (in admin namespace)
  • inflect.uncountable %w[ news ]
  • respond_with :admin, @news

rake routes:
admin_news_index GET /admin/news(.:format) web/admin/news#index
admin_news GET /admin/news/:id(.:format) web/admin/news#show

ActionController::RoutingError: No route matches {:action=>"show", :controller=>"web/admin/news"}
because url is admin_news instead admin_news_index

@josevalim
Copy link
Contributor

Feel free to submit a pull request!

Sent from my iPhone

@nashby
Copy link
Collaborator

nashby commented Sep 27, 2012

Doesn't look like a bug to me. I think it's a normal behaviour that responders is trying to access admin_news url and not admin_news_index. Looks like we need more info on this issue. @darkleaf could you provide a simple application that reproduces this issue?

@darkleaf
Copy link
Author

@nashby
Copy link
Collaborator

nashby commented Sep 27, 2012

@darkleaf I see. Indeed looks like a bug. I'll try to fix it. Thanks!

@nashby
Copy link
Collaborator

nashby commented Sep 27, 2012

@darkleaf hey, awesome news! It was fixed here a37a562 So for now you can use master branch.
@josevalim looks like we need a new release! ❤️

@rafaelfranca
Copy link
Collaborator

I'll cook a new release tonight.

@rafaelfranca
Copy link
Collaborator

I'll leave this issue open to remember to release

@nashby
Copy link
Collaborator

nashby commented Sep 27, 2012

@rafaelfranca I've create a PR with spec to ensure that everything works.

@rafaelfranca
Copy link
Collaborator

Done

@darkleaf
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants