Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Apache tweaks #4

Merged
merged 2 commits into from Apr 21, 2012

Conversation

Projects
None yet
3 participants

smith commented Mar 25, 2012

A few changes for the web recipe:

  • Use the node['apache'] attributes instead of www-data.
  • Don't disable the default site. Not sure about a consensus on this, but I find it annoying when cookbooks disable this and I don't want to on a host. the ServerName directive is set anyway, so it shouldn't be an issue.
  • Remove the NameVirtualHost directive. The opscode apache cookbook sets this in ports.conf.

dje commented Apr 21, 2012

Looks good. Thanks.

dje added a commit that referenced this pull request Apr 21, 2012

@dje dje merged commit d1474bf into heavywater:master Apr 21, 2012

@hectcastro hectcastro commented on the diff Apr 22, 2012

recipes/web.rb
end
-directory "/opt/graphite/storage/whisper" do
- owner "www-data"
- group "www-data"
+%w{ log webapp whisper }.each do |dir|
@hectcastro

hectcastro Apr 22, 2012

I haven't gotten an opportunity to test, but doesn't this change conflict with Graphite's vhost configuration?

https://github.com/heavywater/chef-graphite/blob/master/templates/default/graphite-vhost.conf.erb#L14-15

@smith

smith Apr 24, 2012

Good catch. #7 should address this.

viralshah referenced this pull request in viralshah/chef-graphite Sep 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment