Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new installers location. Avoid infinite loop in translator. Fix #363 #364

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@eiriksm
Copy link
Contributor

commented Aug 14, 2019

No description provided.

@jmolivas

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@enzolutions @harold20 can you take a look at this based on a conversation on slack seems like is caused by this change on the composer/installers composer/installers@4aa453a#diff-2cb8fec6869068770a69d146dbcde76b

@clemens-tolboom

This comment has been minimized.

Copy link

commented Aug 16, 2019

@TonyTheFerg

This comment has been minimized.

Copy link

commented Aug 17, 2019

Thanks, this fixed a memory error I began receiving when trying to ./drupal module:install MODULE after a recent composer update

zrhoffman added a commit to zrhoffman/zrhoffman.net that referenced this pull request Aug 18, 2019
drupal/console-core: Add patch for unmerged PR hechoendrupal/drupal-c…
…onsole-core#364 to avoid infinite recursion trying to find drupal/console-en
@dwkitchen

This comment has been minimized.

Copy link

commented Aug 19, 2019

The resolved the issues for me as well.

@rfsbsb

This comment has been minimized.

Copy link

commented Aug 19, 2019

I can confirm this fix the problem for me as well.

@amaisano

This comment has been minimized.

Copy link

commented Aug 20, 2019

Should the files in the new location be gitignored?

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thanks to @eiriksm for the code and the rest of you for testing.

I will accept this PR and create a new release today.

@clemens-tolboom there is something we could to fix the issue in composer/installer of drupal-composer/drupal-project? BTW thanks for your help in that matter

@enzolutions enzolutions merged commit cf7a95f into hechoendrupal:master Aug 20, 2019

@clemens-tolboom

This comment has been minimized.

Copy link

commented Aug 21, 2019

Is there something we could to fix the issue in composer/installer of drupal-composer/drupal-project?

@enzolutions I've tested this commit. Works fine for me. We don't have to do anything right? Unless I missed something.

People have to:

Correct me if I'm wrong.

@clemens-tolboom

This comment has been minimized.

Copy link

commented Aug 21, 2019

Ai ... I forgot to mention installing latest version of drupal/console (I did a git pull)

@jmolivas

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@clemens-tolboom you will probably want to add console/language to your .gitignore file.

@AlexSkrypnyk

This comment has been minimized.

Copy link

commented Aug 28, 2019

@jmolivas this "hanging" directory started to appear in all projects that use console after the update. Is it possible to avoid the creation of this dir altogether? Also, how come it is doing it in the root of the repo and not in the vendor dir? Is this a bug? Thanks

@clemens-tolboom

This comment has been minimized.

Copy link

commented Aug 28, 2019

AFAIK the idea of the console/language directory is you can add your own translation there and manage those in your own (git) workflow. That is why drupal-composer/drupal-project#509 added it to .gitignore to ignore https://github.com/hechoendrupal/drupal-console-en and potential other public translations.

So IMHO it is not a bug.

@AlexSkrypnyk

This comment has been minimized.

Copy link

commented Aug 28, 2019

@clemens-tolboom Thank you for explanation.

Created #366

@jmolivas

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

This was related to an old PR composer/installers#311 merged to the composer/installers repository that is no longer required.

But got fixed on latest release of the drupal-console project
https://github.com/hechoendrupal/drupal-console/releases/tag/1.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.