Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Launcher on Windows #51

Merged
merged 1 commit into from Nov 13, 2016

Conversation

@luenemam
Copy link
Contributor

luenemam commented Nov 13, 2016

Start with drupal executable.
Don't assume composer always creates a symlink.

Start with drupal executable.
Don't assume composer always creates a symlink.
@luenemam luenemam force-pushed the luenemam:fix-laucher-on-windows branch from f3a1921 to 35de523 Nov 13, 2016
@jmolivas jmolivas merged commit c380929 into hechoendrupal:master Nov 13, 2016
@jmolivas

This comment has been minimized.

Copy link
Member

jmolivas commented Nov 13, 2016

@luenemam Thanks for your contribution, your PR was merged. This will be included on the next release.

@luenemam

This comment has been minimized.

Copy link
Contributor Author

luenemam commented Nov 13, 2016

Thanks too. I'd like to add a test to prevent regression. Any suggestions?

@luenemam luenemam deleted the luenemam:fix-laucher-on-windows branch Nov 14, 2016
@luenemam

This comment has been minimized.

Copy link
Contributor Author

luenemam commented Nov 14, 2016

hechoendrupal/drupal-console#2914 should is fixed now.

davidgrayston pushed a commit to dennisinteractive/drupal-console-launcher that referenced this pull request Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.