Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[generate:plugin:ckeditorbutton] New command #1999
@dinarcon , This is a great start. I'm able to drag and drop the of the icon at the text format configuration(
I have try it out with the Youtube add on as well as with the
I have create a sandbox in Drupal.org - https://www.drupal.org/sandbox/darol100/2683885 so you can checkout if I'm doing something wrong or missing something something.
Here is the addon page - http://ckeditor.com/addon/loremipsum
Hi @darol100, thanks for your review! Your test revealed an oversight which has been fixed already. A new option is required for the command to work. I have provided better instructions to set them correctly. In particular:
In the case of the loremipsum ckeditor button you are working on, the following command will generate the appropriate code:
Please note that following CKEditor's recommendations, the plugin code is suggested to be placed in a 'js/plugins' folder. And make sure to update the path to your icon accordingly. This varies from among plugins.
Please test again.
Even thought CKeditor recommendation is inside of the module, Drupal recommendation is to have it on central location just in case some other module was to use it. In D7 we use to store our external libraries at
@dinarcon What do you think ?
@darol100 It is possible to change the code to point to the location of preference. The default is just a suggestion which is based on both CKEditor's recommendations and Drupal's own plugin implementations. Contrib is also following this pattern. Maybe we can open an issue on drupal.org to further discuss this.
In terms of functionality, is the current implementation showing the button on the editing screen and working as expected? It would be great to test other CKEditor plugins to verify this works for all cases.