New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventions for Test classes and its Data Providers. #2891

Merged
merged 1 commit into from Nov 8, 2016

Conversation

Projects
None yet
3 participants
@MontealegreLuis
Copy link
Member

MontealegreLuis commented Nov 6, 2016

  • Rename and move tests classes to match class and package names of its subjects under test.
    • This improves the navigation between test and test subject. (ctrl+shift+T in PHPStorm for instance).
  • Add keys to the arrays in the data providers traits.
    • Adding keys to every data set will improve the error message provided by PHPUnit
      • ... with data set "Container aware" ...
    • Adding keys to every element in the data set will explain its content and provide context.
      • 'module' => 'foo' instead of only 'foo'
Rename test classes to match its subjects class' names.
* Rename and move tests classes to match class and package names
   of its subjects under test.
* Add keys to the arrays in the data providers methods.

@jmolivas jmolivas added the in progress label Nov 6, 2016

@dmouse dmouse merged commit f23b942 into hechoendrupal:develop Nov 8, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jmolivas jmolivas removed the in progress label Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment