Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructor args in two commands (#3041) #3044

Merged

Conversation

@cburschka
Copy link
Contributor

@cburschka cburschka commented Dec 25, 2016

  • config:validate overrides the parent constructor's optional
    name argument with a constructor that requires it.

  • generate:module requires an argument that is not defined in
    the corresponding services file, and should be optional.

- config:validate overrides the parent constructor's optional
  name argument with a constructor that requires it.

- generate:module requires an argument that is not defined in
  the corresponding services file, and should be optional.
@jmolivas jmolivas merged commit 24f519b into hechoendrupal:master Dec 27, 2016
1 check passed
@jmolivas
Copy link
Member

@jmolivas jmolivas commented Dec 27, 2016

@cburschka Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas jmolivas added this to the 1.0.0-rc13 milestone Dec 27, 2016
@jmolivas jmolivas added this to the 1.0.0-rc13 milestone Dec 27, 2016
@cburschka cburschka deleted the feature/3041-command-parameters branch Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants