Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generate:plugin:migrate:dataparser] Add new command for generating data parser plugin for migration. Fix #3773 #3774

Merged
merged 7 commits into from Apr 22, 2018

Conversation

Projects
None yet
3 participants
@joshirohit100
Copy link
Contributor

commented Feb 9, 2018

Issue - #3773

protected function configure()
{
$this
->setName('generate:plugin:migrate:data_parser')

This comment has been minimized.

Copy link
@LOBsTerr

LOBsTerr Feb 9, 2018

Member

@joshirohit100 Normally, underscore is not used in command name.
some examples generate:plugin:rulesaction, generate:plugin:rulesaction and etc.

Maybe it would be better to use something like this generate:plugin:migrate:data:parse. So, if we add also data fetcher we will have generate:plugin:migrate:data:fetcher. What do you think ?

This comment has been minimized.

Copy link
@joshirohit100

joshirohit100 Feb 9, 2018

Author Contributor

I am fine with both generate:plugin:migrate:dataparser or generate:plugin:migrate:data:parse
Lets see what other say

This comment has been minimized.

Copy link
@jmolivas

jmolivas Feb 12, 2018

Member

I like generate:plugin:migrate:dataparser better

This comment has been minimized.

Copy link
@joshirohit100

joshirohit100 Feb 20, 2018

Author Contributor

Thanks! I have updated the PR

@jmolivas jmolivas changed the title [#3773] Adding new command for generating data parser plugin for migration. [generate:plugin:migrate:dataparser] Add new command for generating data parser plugin for migration. Fix #3773 Feb 12, 2018

@jmolivas jmolivas added this to the 1.6.1 milestone Feb 14, 2018

@jmolivas jmolivas modified the milestones: 1.7.0, 1.8.0 Mar 6, 2018

@joshirohit100

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2018

@jmolivas waiting for this :)

@jmolivas jmolivas merged commit 927a11b into hechoendrupal:master Apr 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.