Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3275 remove translation code #3822

Merged
merged 2 commits into from Apr 22, 2018

Conversation

Projects
None yet
3 participants
@LOBsTerr
Copy link
Member

commented Mar 13, 2018

Remove translations related code if we didn't choose entity as translatable

@Alluuu

This comment has been minimized.

Copy link

commented Mar 13, 2018

Is langcode required, or I can manually remove it if I wish to? (I'm slightly confused by the comment of it being default)

@LOBsTerr

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2018

@Alluuu I removed the langcode at the previous commit, then I realized that this is base field, there are no reasons to remove it and put it back
More information is here: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21ContentEntityBase.php/function/ContentEntityBase%3A%3AbaseFieldDefinitions/8.2.x

@jmolivas jmolivas added this to the 1.9.0 milestone Apr 22, 2018

@jmolivas jmolivas merged commit f5fd6de into hechoendrupal:master Apr 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.