Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules] Fix validation in ProjectDownloadTrait #3870

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@harold20
Copy link
Contributor

commented Apr 20, 2018

No description provided.

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

@harold20 The PR for this fix already exists #3855
I'm closing this one

@LOBsTerr LOBsTerr closed this Apr 21, 2018

@harold20

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2018

I had not seen it @LOBsTerr, but you must update your PR because the solution of the moduleUninstall function is missing. If you see the function, the variable moduleName is incorrect in is_numeric validation.

@LOBsTerr LOBsTerr reopened this Apr 23, 2018

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

@harold20 Nice catch, I didn't notice it

@LOBsTerr LOBsTerr merged commit bd35d15 into hechoendrupal:master Apr 23, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jmolivas jmolivas removed the in progress label Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.