Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multisite:new] fix so that multi site command uses uri argument #3871

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
4 participants
@t14
Copy link
Contributor

commented Apr 22, 2018

Problem/Motivation

When running the drupal multisite:new the second argument uri is never used and the directory argument is used in its place making it impossible to take full advantage of all the functionality in the sites.php file that this command writes to

How to reproduce

run Drupal multisite:new new-site http://new-site.example.com
In sites.php you will see $sites['new-site'] = 'new-site';
When the final result should actually be $sites['http://new-site.example.com'] = 'new-site';

Solution

The solution in this PR fixes the issues

@jmolivas jmolivas added this to the 1.9.0 milestone Apr 22, 2018

@harold20

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Hi @t14 thanks for this PR.

Only one question. Is it practical to have a different name between the directory and the uri? because with your change this can happen.

@harold20

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

I just create this PR @enzolutions #4039 to validate the url name, because I had a problem with the console if I define the uri name starting with http://

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Thanks @t14

@enzolutions enzolutions merged commit 6fe73b3 into hechoendrupal:master May 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.