Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Paragraph type export command #3880

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@joe-mcpherson
Copy link
Contributor

commented May 1, 2018

Added Paragraph type export to export Paragraph type's fields with following command:

drupal config:export:paragraph:type

(Translation in separate pull request on drupal-console-en repository)

Added Paragraph type export to export Paragraph type's fields with co…
…mmand drupal config:export:paragraph:type
@LOBsTerr

This comment has been minimized.

Copy link
Member

commented May 2, 2018

@jmolivas I propose universal solution #3875. This will reduce amount of code we have to support. (#3794)

If we still need export of entity as separate command we should use chain instead, but still I don't think it will be useful, if we have a generic command

@joe-mcpherson

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

@LOBsTerr I agree a generic solution makes more sense. I didn't see your proposal, I just needed this for a project I was working on so thought I'd throw it back if it could be useful for someone

@jmolivas

This comment has been minimized.

Copy link
Member

commented May 9, 2018

@LOBsTerr I have to say I like those commands to export configurations and use the result on a custom profile.

I also agree a generic solution one single command could be easy to maintain since is one command but maybe the code gets a little complex since is taking a lot of considerations.

@jmolivas jmolivas added this to the 1.9.0 milestone May 9, 2018

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented May 9, 2018

@jmolivas I'm absolutely agree with and in fact I have just a little bit extended the current code and I moved the common classes to the trait ExportTrait.php. Check the PR https://github.com/hechoendrupal/drupal-console/pull/3875/files

@anuragshah17

This comment has been minimized.

Copy link

commented Mar 1, 2019

@joe-mcpherson Hey i am trying to apply patch for this pull, not working with Drupal Console 1.0.1 version. I need to try this with dev version for Drupal Console?

@anuragshah17

This comment has been minimized.

Copy link

commented Mar 4, 2019

@joe-mcpherson Please ignore above message. Command worked with 1.8.0 version.
Thanks

@542digital
Copy link

left a comment

Quite up for this being merged in.

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

I was thinking why we limit us only to specific config entities and I added a new commit, which expose all config entities, because I have seen recently request about media type also. Please, test it #3875

@LOBsTerr LOBsTerr merged commit e30b14d into hechoendrupal:master Mar 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

LOBsTerr added a commit that referenced this pull request Mar 19, 2019

Revert "Added Paragraph type export to export Paragraph type's fields…
… with command drupal config:export:paragraph:type (#3880)"

This reverts commit e30b14d.

LOBsTerr added a commit that referenced this pull request Mar 19, 2019

Revert "Added Paragraph type export to export Paragraph type's fields…
… with command drupal config:export:paragraph:type (#3880)" (#4009)

This reverts commit e30b14d.
@LOBsTerr

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

I have merged #3875
There you can export any config entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.