Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding standards for generate:form command. #3900

Merged

Conversation

Projects
None yet
3 participants
@kporras07
Copy link
Contributor

commented Jun 6, 2018

Make the generated code comply with Coding Standards

How to test:

  • Generate module named "mymodule"
  • Generate form with this command: drupal generate:form --module="mymodule" --class="DefaultForm" --form-id="default_form" --services='current_user' --config-file --inputs='"name":"text_field", "type":"textfield", "label":"text field", "options":"", "description":"", "maxlength":"64", "size":"64", "default_value":"", "weight":"0", "fieldset":""' --path="/mymodule/form/default" --learning --uri="http://default" --no-interaction
  • Evaluate coding standards (ex. phpcs --standard=Drupal web/modules/custom/mymodule/*)
  • It should pass

@jmolivas jmolivas added this to the 1.9.0 milestone Jun 28, 2018

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Thank you for contribution

@LOBsTerr LOBsTerr merged commit 22490f2 into hechoendrupal:master Apr 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.