Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generate:entity:content] Grant correct view permissions for revisions #3933

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@absoludo
Copy link
Contributor

commented Sep 25, 2018

Problem/Motivation

After generating a content entity with revisions users cannot be given access tot the entity revision.

Details to include:

  • Why are we doing this? Above all, a summary should explain why a change is needed, in a few short sentences.

How to reproduce

Generate a new content entity (in my case without bundles & translations, but with revisions). Check the *.permissions.yml & the *HtmlRouteProvider.php for the mismatching permissions.

Details to include:

  • Drupal Console Launcher version 1.8.0
  • Drupal Console version 1.8.0

Solution

In the *HtmlRouteProvider.php the permision access %entity_type revisions should be called view all %entity_type revisions.

@absoludo absoludo changed the title Grant [generate:entity:content] correct view permissions for revisions (#3932) Grant [generate:entity:content] correct view permissions for revisions Sep 25, 2018

@absoludo absoludo changed the title Grant [generate:entity:content] correct view permissions for revisions [generate:entity:content] Grant correct view permissions for revisions Sep 25, 2018

@LOBsTerr LOBsTerr added this to the 1.9.0 milestone Sep 28, 2018

@LOBsTerr LOBsTerr merged commit 912508f into hechoendrupal:master Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.