Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4006 serialize #4013

Merged
merged 9 commits into from Jul 3, 2019

Conversation

Projects
None yet
4 participants
@LOBsTerr
Copy link
Member

commented Apr 5, 2019

No description provided.

@JeffVeit
Copy link

left a comment

Works for me on generate:form:config, which suffered the same problem.

@Fonata

This comment has been minimized.

Copy link

commented Jun 13, 2019

Please provide some information why this PR was closed.

This PR solved my problem with config:export:single I had in both Console 1.8.0 and 1.9.0.

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

@Fonata was closed because we were unable to preoduce in latest version 1.9.0, please test again and if fails, please let us now how to reproduce to reopen.

@Fonata

This comment has been minimized.

Copy link

commented Jun 14, 2019

@enzolutions Here is a slightly artificial command that allows to reproduce the problem:
drupal config:export:single --name=system.site --remove-config-hash --remove-uuid --module=webform --optional

It crashes for Console 1.9.0, but not with this PR. I am using Drupal Core 8.7.2 and PHP 7.1.29.

Despite the scary error message, the YAML file seems to be created correctly.

Here is the output for Console 1.9.0:

christian@lenovo-pc /var/www/hub/vendor/drupal/console ((1.9.0)) $ drupal config:export:single --name=system.site --remove-config-hash --remove-uuid --module=webform --optional
 Configuration(s) exported successfully
- modules/contrib/webform/config/optional/system.site.yml

                                                                                                                        
 [ERROR] <em class="placeholder">Warning</em>: call_user_func_array() expects parameter 1 to be a valid callback,       
         class 'SplFileInfo' does not have a method 'serialize' in <em                                                  
         class="placeholder">Drupal\Core\Extension\Extension-&gt;__call()</em> (line <em class="placeholder">160</em>   
         of <em class="placeholder">core/lib/Drupal/Core/Extension/Extension.php</em>). <pre                            
         class="backtrace">Drupal\Core\Extension\Extension-&gt;__call(&#039;serialize&#039;, Array) (Line: 314)         
         Drupal\Console\Extension\Manager-&gt;createExtension(Object) (Line: 251)                                       
         Drupal\Console\Extension\Manager-&gt;getModule(&#039;webform&#039;) (Line: 86)                                 
         Drupal\Console\Command\Config\ExportSingleCommand-&gt;exportConfigToModule(&#039;webform&#039;,                
         &#039;Configuration(s) exported successfully&#039;) (Line: 300)                                                
         Drupal\Console\Command\Config\ExportSingleCommand-&gt;execute(Object, Object) (Line: 255)                      
         Symfony\Component\Console\Command\Command-&gt;run(Object, Object) (Line: 987)                                  
         Symfony\Component\Console\Application-&gt;doRunCommand(Object, Object, Object) (Line: 255)                     
         Symfony\Component\Console\Application-&gt;doRun(Object, Object) (Line: 188)                                    
         Drupal\Console\Core\Application-&gt;doRun(Object, Object) (Line: 64)                                           
         Drupal\Console\Application-&gt;doRun(Object, Object) (Line: 148)                                               
         Symfony\Component\Console\Application-&gt;run() (Line: 89)                                                     
         require(&#039;/app/vendor/drupal/console/bin/drupal.php&#039;) (Line: 4)                                       
         </pre>                                                                                                                                                                                                                             

@enzolutions enzolutions reopened this Jul 3, 2019

@enzolutions enzolutions merged commit fca9572 into hechoendrupal:master Jul 3, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.