Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config:export:content:type] Fixed conflicts and add missing services #4036

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
4 participants
@harold20
Copy link
Contributor

commented May 14, 2019

This PR is an extension of #3846 and resolved missing code and conflicts

@enzolutions enzolutions merged commit c2c3efb into hechoendrupal:master May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LOBsTerr

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@enzolutions I have reverted my changes, which uses "config:export:entity" as chain command.
I have added it. In order to reduce duplication and make it more easier to export any entity.

$this->chainQueue->addCommand(
            'config:export:entity', [
                'entity-type' => 'node_type',
                'bundle' => $contentType,
                '--module' => $module,
                '--optional-config' => $optionalConfig,
                '--remove-uuid' => $removeUuid,
                '--remove-config-hash' => $removeHash
            ]
        );
@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Hi, @LOBsTerr Do you mean we need to revert this merge? and you will create another PR to introduce your suggestion?

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I will create a new pr, with the current improvements and my changes

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Awesome @LOBsTerr

@LOBsTerr

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@enzolutions Everything should be here: #4044

More information in my new PR: #4045

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Awesome, we will review an merge soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.