Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4044 config export all option #4045

Merged

Conversation

Projects
None yet
3 participants
@LOBsTerr
Copy link
Member

commented May 16, 2019

  1. Add export all option like it was done in content type export command
  2. Replace content type export command with chainQueue which will call Entity export command inside
  3. Replace view export command with chainQueue which will call Entity export command inside
  4. Add include dependencies option for content type export command and for entity export commands
  5. Small code refactoring
  6. Fix issue with HASH and UUID removal for some configuration
  7. Replace option all with "-all-", because we can have bundle name all

LOBsTerr added some commits May 16, 2019

Add include dependency option for content type export, entity config …
…export. Replace view export command with chainQueue
@harold20

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Hi @LOBsTerr thanks for the PR.

I was reviewing the PR and I find an issue. If I choose the option all, all the config to export within $this->configExport are generated in each content type (I showed the content type name to clearly see the error)

demo

To fix it, you need to empty $this->configExport after exporting each content type

image

I hope you can fix it to merged. :)

@LOBsTerr

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

@harold20 Thanks for review. Nice catch. It has been fixed

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Thanks @LOBsTerr and @harold20

@enzolutions enzolutions merged commit a026e44 into hechoendrupal:master May 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.