Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site:install] Improve support of --db-url #4049

Merged
merged 7 commits into from May 21, 2019

Conversation

Projects
None yet
2 participants
@mondrake
Copy link
Contributor

commented May 21, 2019

Looking at the newly introduced --db-url argument for site:install, I believe there's room for some improvements.

If --db-url is specified and valid, there is no purpose to go through the other options. We can just install based on that.

Here's my suggested changes - not for merging yet but rather for sharing with the community - I am new to Drupal console contribution so please bear with me.

My goal: allow site:install to run on ANY database driver (also contributed), as long as it complies to the Drupal API for Database::convertDbUrlToConnectionInfo and Database::getConnectionInfoAsUrl.

10
@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Thank you @mondrake for your contribution

@enzolutions enzolutions merged commit 1247f20 into hechoendrupal:master May 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mondrake mondrake deleted the mondrake:site-install branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.