Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site:install] Small improvements #4061

Merged
merged 4 commits into from May 23, 2019

Conversation

Projects
None yet
2 participants
@mondrake
Copy link
Contributor

commented May 23, 2019

  1. If Drupal is already installed, and --force is not set, there's no point to continue an interactive install that will lead to an error anyway. Exit early.
  2. The Drupal installer, when erroring out, returns HTML, not good for displaying on CLI. Cleanup from tags and entities before outputting.
  3. A trivial bug fix at lines 271-272
  4. Few doc cleanups

mondrake added some commits May 23, 2019

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Hi @mondrake

Thanks for your contribution. I just followed the issue that you opened https://www.drupal.org/project/drupal/issues/3056698, I will check again when that issue get resolved in Drupal Core

@enzolutions enzolutions merged commit 131bb18 into hechoendrupal:master May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mondrake mondrake deleted the mondrake:site-install-2 branch May 24, 2019

@mondrake

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Thanks @enzolutions

Anyone watching, reviews @ https://www.drupal.org/project/drupal/issues/3056698 appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.