Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site:status] improvements #4063

Merged
merged 25 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@mondrake
Copy link
Contributor

commented May 24, 2019

  1. I find the current output of ss a bit too verbose - greatly prefer the more succint results in 1.8.0. So I am proposing to print out the description only if verbose mode is on i.e. the -v flag is set -> drupal site:status -v
  2. Color coding errors and warnings according to severity of the requirement. This makes ss consistent with Drupal core's 'Status report' webpage.
  3. Skip reporting empty keys in the database connection options.

See new results below (non-verbose)
Schermata 2019-05-24 alle 21 27 07

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

@mondrake this is ready to review, to see if we could include in the next release 1.9.0 next week?

@mondrake

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

yea, no more changes from my side

Show resolved Hide resolved src/Command/Site/StatusCommand.php Outdated
Show resolved Hide resolved src/Command/Site/StatusCommand.php Outdated
@mondrake

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

Done, thanks for review @harold20

@mondrake

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@harold20

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Hey @mondrake that new commit has problems related with the "if", You forget close the condition. Could you fix it?

22
@mondrake

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

Sorry. Fixed and did a bit more cleaning.

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Thanks @mondrake

@enzolutions enzolutions merged commit df8b95b into hechoendrupal:master May 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mondrake mondrake deleted the mondrake:site-status branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.