Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capability to accept updates via command option #4109

Merged
merged 3 commits into from Jul 15, 2019

Conversation

@lalop
Copy link
Contributor

commented Jul 5, 2019

see #4108

@lalop

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

the yes option is define in https://github.com/hechoendrupal/drupal-console-core/blob/master/src/Application.php#L429-L436

this patch affect only this command but we can image adding this in the confirm method to bypass any confirmation ?

@lalop

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

As seen with @jmolivas I added a micro-patch to remove dead code in the same command.

@lalop

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@enzolutions any chance to see this merged soon ?

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@lalop we will try to review to include in our next release 1.9.1 in a week or two. We have been putting our effort to migrate the documentation and website of Drupal Console to Gatsby https://drupal-console.web.app/docs/fa-ir/chains/what-is-a-chain-command

Show resolved Hide resolved src/Command/Update/ExecuteCommand.php Outdated
@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Thanks @lalop

@enzolutions enzolutions merged commit e6e3332 into hechoendrupal:master Jul 15, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.